Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile/record sleep scaffold #54

Merged
merged 40 commits into from
Nov 5, 2020
Merged

Mobile/record sleep scaffold #54

merged 40 commits into from
Nov 5, 2020

Conversation

mateobelanger
Copy link
Contributor

@mateobelanger mateobelanger commented Oct 29, 2020 •
edited
Loading

Scaffold for mobile app:

  • Dashboard page (home)
  • Bluetooth connection page
  • Record Sleep guide page

Added automatic routes management with auto_router
High level navigation through an app drawer
Experimenting with chart lib
Renamed and moved some of Mourad's file so conflicts are expected

@abelfodil abelfodil force-pushed the mobile/record-sleep-scaffold branch from 7285454 to 16bbe80 Compare October 29, 2020 12:57
abelfodil
abelfodil requested changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@abelfodil abelfodil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few remarks here:

  • The app crashes on start
  • Run flutter format **/*.dart
  • Merge master and fix potential pipeline errors

.gitignore Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
mobile/lib/src/app.dart Outdated Show resolved Hide resolved
mobile/lib/src/presentation/navigation/routes/router.gr.dart Outdated Show resolved Hide resolved
mobile/pubspec.yaml Outdated Show resolved Hide resolved
mobile/lib/src/application/blocs.dart Outdated Show resolved Hide resolved
mobile/lib/src/application/navdrawer/navdrawer_bloc.dart Outdated Show resolved Hide resolved
mobile/lib/src/application/navdrawer/navdrawer_event.dart Outdated Show resolved Hide resolved
@PolyCortex PolyCortex deleted a comment from WilliamHarvey97 Oct 29, 2020
@mateobelanger mateobelanger marked this pull request as draft November 3, 2020 05:44
abelfodil
abelfodil previously requested changes Nov 3, 2020
View reviewed changes
mobile/.gitignore Outdated Show resolved Hide resolved
mobile/polydodo-mobile.code-workspace Outdated Show resolved Hide resolved
mobile/pubspec.yaml Outdated Show resolved Hide resolved
mobile/lib/src/presentation/widgets/simple_line_chart.dart Outdated Show resolved Hide resolved
mobile/lib/src/presentation/widgets/simple_line_chart.dart Outdated Show resolved Hide resolved
mobile/lib/src/presentation/widgets/simple_line_chart.dart Outdated Show resolved Hide resolved
mobile/lib/src/presentation/widgets/simple_line_chart.dart Outdated Show resolved Hide resolved
mobile/lib/src/presentation/widgets/simple_line_chart.dart Outdated Show resolved Hide resolved
mobile/lib/src/presentation/navigation/routes/router.dart Outdated Show resolved Hide resolved
@mateobelanger mateobelanger marked this pull request as ready for review November 5, 2020 07:31
@mateobelanger mateobelanger merged commit 1eeae48 into master Nov 5, 2020
@mateobelanger mateobelanger deleted the mobile/record-sleep-scaffold branch November 5, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abelfodil abelfodil abelfodil approved these changes

@WilliamHarvey97 WilliamHarvey97 Awaiting requested review from WilliamHarvey97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mateobelanger @abelfodil @WilliamHarvey97